summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGabriel Schulhof <gabriel.schulhof@intel.com>2020-11-17 16:43:59 -0800
committerBeth Griggs <bgriggs@redhat.com>2020-12-15 20:15:24 +0000
commitd49e0ca73ad0a18c3321e4b44eb759817c1cbef5 (patch)
tree21ebdd7b27c57fcf02b3edf35e113c854aee2431
parent127a4fb8104d513d96a597583335c8ed676cb28f (diff)
downloadnode-new-d49e0ca73ad0a18c3321e4b44eb759817c1cbef5.tar.gz
benchmark: fix build warnings
The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/36157 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
-rw-r--r--benchmark/napi/function_args/binding.cc4
-rw-r--r--benchmark/napi/function_call/binding.cc4
2 files changed, 6 insertions, 2 deletions
diff --git a/benchmark/napi/function_args/binding.cc b/benchmark/napi/function_args/binding.cc
index 2c54dd424d..078fe0ee3e 100644
--- a/benchmark/napi/function_args/binding.cc
+++ b/benchmark/napi/function_args/binding.cc
@@ -123,7 +123,9 @@ void CallWithArguments(const FunctionCallbackInfo<Value>& args) {
}
}
-void Initialize(Local<Object> target) {
+void Initialize(Local<Object> target,
+ Local<Value> module,
+ void* data) {
NODE_SET_METHOD(target, "callWithString", CallWithString);
NODE_SET_METHOD(target, "callWithLongString", CallWithString);
diff --git a/benchmark/napi/function_call/binding.cc b/benchmark/napi/function_call/binding.cc
index 289a94ac3e..570f96f41e 100644
--- a/benchmark/napi/function_call/binding.cc
+++ b/benchmark/napi/function_call/binding.cc
@@ -7,7 +7,9 @@ void Hello(const v8::FunctionCallbackInfo<v8::Value>& args) {
args.GetReturnValue().Set(c++);
}
-void Initialize(v8::Local<v8::Object> target) {
+void Initialize(v8::Local<v8::Object> target,
+ v8::Local<v8::Value> module,
+ void* data) {
NODE_SET_METHOD(target, "hello", Hello);
}