diff options
| author | Anna Henningsen <anna@addaleax.net> | 2020-04-28 04:53:52 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2020-05-04 14:23:26 +0200 |
| commit | af7da46d9bae0e3b69f6a7c53317c661cc61c327 (patch) | |
| tree | 0e1ad397c22da083af6a2480b3c98d68bac56b9e | |
| parent | 9ccb6b2e8c1fd78e97bed360b45dfc62448a1962 (diff) | |
| download | node-new-af7da46d9bae0e3b69f6a7c53317c661cc61c327.tar.gz | |
test: fix out-of-bound reads from invalid sizeof usage
`sizeof(data)` does not return the correct result here, as it measures
the size of the `data` variable, not what it points to.
PR-URL: https://github.com/nodejs/node/pull/33115
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | test/addons/worker-buffer-callback/binding.cc | 2 | ||||
| -rw-r--r-- | test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/test/addons/worker-buffer-callback/binding.cc b/test/addons/worker-buffer-callback/binding.cc index f600f410c1..ac4c0cb498 100644 --- a/test/addons/worker-buffer-callback/binding.cc +++ b/test/addons/worker-buffer-callback/binding.cc @@ -30,7 +30,7 @@ void Initialize(Local<Object> exports, node::Buffer::New( isolate, data, - sizeof(data), + sizeof(char), [](char* data, void* hint) { delete data; free_call_count++; diff --git a/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c b/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c index 3275551aee..b4f2e288ec 100644 --- a/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c +++ b/test/node-api/test_worker_buffer_callback/test_worker_buffer_callback.c @@ -35,7 +35,7 @@ NAPI_MODULE_INIT() { NAPI_CALL(env, napi_create_external_arraybuffer( env, data, - sizeof(data), + sizeof(char), finalize_cb, NULL, &buffer)); |