diff options
| author | Rich Trott <rtrott@gmail.com> | 2020-07-11 18:12:18 -0700 |
|---|---|---|
| committer | Myles Borins <mylesborins@github.com> | 2020-07-16 17:09:12 -0400 |
| commit | 28ce378e176790f26a121cd72f8f37f50866132e (patch) | |
| tree | f736a507be2d23c10de766c507ac148f5014bda4 | |
| parent | 8f8d16849cf9cd48026f5af4add6f06e323eeae0 (diff) | |
| download | node-new-28ce378e176790f26a121cd72f8f37f50866132e.tar.gz | |
test: fix flaky test-http2-reset-flood
Set `allowHalfOpen: true` in the client.
Fixes: https://github.com/nodejs/node/issues/29802
Refs: https://github.com/nodejs/node/pull/31806
PR-URL: https://github.com/nodejs/node/pull/34318
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
| -rw-r--r-- | test/parallel/parallel.status | 4 | ||||
| -rw-r--r-- | test/parallel/test-http2-reset-flood.js | 2 |
2 files changed, 1 insertions, 5 deletions
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index d95b3e45d4..b50684d96f 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -5,8 +5,6 @@ prefix parallel # sample-test : PASS,FLAKY [true] # This section applies to all platforms -# https://github.com/nodejs/node/issues/29802 -test-http2-reset-flood: PASS,FLAKY [$system==win32] # https://github.com/nodejs/node/issues/32863 @@ -48,8 +46,6 @@ test-fs-stream-construct: PASS,FLAKY [$system==freebsd] # https://github.com/nodejs/node/issues/31727 test-fs-stat-bigint: PASS,FLAKY -# https://github.com/nodejs/node/issues/29802 -test-http2-reset-flood: PASS,FLAKY # https://github.com/nodejs/node/issues/28803 test-stdout-close-catch: PASS,FLAKY # https://github.com/nodejs/node/issues/31280 diff --git a/test/parallel/test-http2-reset-flood.js b/test/parallel/test-http2-reset-flood.js index 25520f81f2..a209708620 100644 --- a/test/parallel/test-http2-reset-flood.js +++ b/test/parallel/test-http2-reset-flood.js @@ -28,7 +28,7 @@ if (process.env.HAS_STARTED_WORKER) { process.env.HAS_STARTED_WORKER = 1; const worker = new Worker(__filename).on('message', common.mustCall((port) => { const h2header = Buffer.alloc(9); - const conn = net.connect(port); + const conn = net.connect({ port, allowHalfOpen: true }); conn.write('PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n'); |