diff options
| author | Ruy Adorno <ruyadorno@hotmail.com> | 2020-07-15 10:55:28 -0400 |
|---|---|---|
| committer | Myles Borins <mylesborins@github.com> | 2020-07-27 18:13:04 -0400 |
| commit | 7d058a4c014461a42d39f5bb96c25e5487049b67 (patch) | |
| tree | ef6a7952fc617a8ec5c9e1ba34978973c3902f9c | |
| parent | a3c9f75b7ed0e7725d7e084395ed75249c2c1594 (diff) | |
| download | node-new-7d058a4c014461a42d39f5bb96c25e5487049b67.tar.gz | |
doc: add author-ready label ref to onboarding doc
The "Labels" section of doc/guides/onboarding-extras.md was missing a
reference to the `author-ready` label. This commit adds a description
similar to the definition found in doc/guides/collaborator-guide.md
with the goal of making it easier for new contributors to find labels
info all in one place.
PR-URL: https://github.com/nodejs/node/pull/34381
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
| -rw-r--r-- | doc/guides/onboarding-extras.md | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/doc/guides/onboarding-extras.md b/doc/guides/onboarding-extras.md index 91ed05d9d3..de7d230217 100644 --- a/doc/guides/onboarding-extras.md +++ b/doc/guides/onboarding-extras.md @@ -24,7 +24,19 @@ request. * `tsc-agenda` - Open issues and pull requests with this label will be added to the Technical Steering Committee meeting agenda --- +--- + +* `author-ready` - A pull request is _author ready_ when: + * There is a CI run in progress or completed. + * There is at least one Collaborator approval (or two TSC approvals + for semver-major PRs). + * There are no outstanding review comments. + +Please always add the `author ready` label to the pull request in that case. +Please always remove it again as soon as the conditions are not met anymore, +such as if CI run fails or a new outstanding review comment is posted. + +--- * `semver-{minor,major}` * be conservative – that is, if a change has the remote *chance* of breaking |