diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2020-07-24 12:46:13 -0400 |
|---|---|---|
| committer | Myles Borins <mylesborins@github.com> | 2020-07-27 18:23:47 -0400 |
| commit | a4806e2d12982c80d2aff7245b3a316c560f7920 (patch) | |
| tree | 9e6b76cb0e6f6040efc5475d1cd7ba7f5943a9ca | |
| parent | f7600d5ab6386203ea0870332729aae194b5ef16 (diff) | |
| download | node-new-a4806e2d12982c80d2aff7245b3a316c560f7920.tar.gz | |
build: speed up source tarball creation
Avoid building the node binary when building the source tarball. We
need a node binary to build the docs, but it doesn't have to be one
we build from scratch and can reuse any available node binary.
Skip building the xz compressed tarball in the build-tarball workflow
as we only use the gzip compressed tarball in the subsequent build
jobs.
PR-URL: https://github.com/nodejs/node/pull/34508
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
| -rw-r--r-- | .github/workflows/build-tarball.yml | 4 | ||||
| -rw-r--r-- | Makefile | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/build-tarball.yml b/.github/workflows/build-tarball.yml index c1d3f30408..699efb39d1 100644 --- a/.github/workflows/build-tarball.yml +++ b/.github/workflows/build-tarball.yml @@ -26,8 +26,8 @@ jobs: run: | export DISTTYPE=nightly export DATESTRING=`date "+%Y-%m-%d"` - export COMMIT=xxxx - ./configure && make tar -j8 + export COMMIT=$(git rev-parse --short=10 "$GITHUB_SHA") + ./configure && make tar -j8 SKIP_XZ=1 mkdir tarballs mv *.tar.gz tarballs - name: Upload tarball artifact @@ -1034,7 +1034,7 @@ pkg-upload: pkg scp -p $(TARNAME).pkg $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME).pkg.done" -$(TARBALL): release-only $(NODE_EXE) doc +$(TARBALL): release-only doc-only git checkout-index -a -f --prefix=$(TARNAME)/ mkdir -p $(TARNAME)/doc/api cp doc/node.1 $(TARNAME)/doc/node.1 |