summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorcjihrig <cjihrig@gmail.com>2020-07-22 19:51:24 -0400
committerMichaƫl Zasso <targos@protonmail.com>2020-10-18 20:17:43 +0200
commitca8f3ef2e550dba41ec8e08e53bc51680623f743 (patch)
tree0367b5601bd0b987c9f67a56618bc6fb73c4886f
parent94dd7b9f94fd151195820e961de997a0ad7ca40a (diff)
downloadnode-new-ca8f3ef2e550dba41ec8e08e53bc51680623f743.tar.gz
wasi: drop --experimental-wasm-bigint requirement
After the V8 8.5 update, the WASI APIs no longer require the use of --experimental-wasm-bigint. This commit removes its use. PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
-rw-r--r--doc/api/wasi.md4
-rw-r--r--test/wasi/test-return-on-exit.js2
-rw-r--r--test/wasi/test-wasi-not-started.js1
-rw-r--r--test/wasi/test-wasi-stdio.js2
-rw-r--r--test/wasi/test-wasi-symlinks.js1
-rw-r--r--test/wasi/test-wasi.js1
6 files changed, 4 insertions, 7 deletions
diff --git a/doc/api/wasi.md b/doc/api/wasi.md
index decb9641e1..5430ae63d5 100644
--- a/doc/api/wasi.md
+++ b/doc/api/wasi.md
@@ -70,8 +70,8 @@ Use [wabt](https://github.com/WebAssembly/wabt) to compile `.wat` to `.wasm`
$ wat2wasm demo.wat
```
-The `--experimental-wasi-unstable-preview1` and `--experimental-wasm-bigint`
-CLI arguments are needed for this example to run.
+The `--experimental-wasi-unstable-preview1` CLI argument is needed for this
+example to run.
## Class: `WASI`
<!-- YAML
diff --git a/test/wasi/test-return-on-exit.js b/test/wasi/test-return-on-exit.js
index 3f5d40c9ba..362d13b490 100644
--- a/test/wasi/test-return-on-exit.js
+++ b/test/wasi/test-return-on-exit.js
@@ -1,4 +1,4 @@
-// Flags: --experimental-wasi-unstable-preview1 --experimental-wasm-bigint
+// Flags: --experimental-wasi-unstable-preview1
'use strict';
const common = require('../common');
const assert = require('assert');
diff --git a/test/wasi/test-wasi-not-started.js b/test/wasi/test-wasi-not-started.js
index ad13e6d711..14c8cdfddf 100644
--- a/test/wasi/test-wasi-not-started.js
+++ b/test/wasi/test-wasi-not-started.js
@@ -29,7 +29,6 @@ if (process.argv[2] === 'wasi-child') {
const child = cp.spawnSync(process.execPath, [
'--experimental-wasi-unstable-preview1',
- '--experimental-wasm-bigint',
__filename,
'wasi-child'
], {
diff --git a/test/wasi/test-wasi-stdio.js b/test/wasi/test-wasi-stdio.js
index d49fa67ce7..90ab7caa83 100644
--- a/test/wasi/test-wasi-stdio.js
+++ b/test/wasi/test-wasi-stdio.js
@@ -1,4 +1,4 @@
-// Flags: --experimental-wasi-unstable-preview1 --experimental-wasm-bigint
+// Flags: --experimental-wasi-unstable-preview1
'use strict';
const common = require('../common');
const tmpdir = require('../common/tmpdir');
diff --git a/test/wasi/test-wasi-symlinks.js b/test/wasi/test-wasi-symlinks.js
index b4f306916a..f10bcd01fe 100644
--- a/test/wasi/test-wasi-symlinks.js
+++ b/test/wasi/test-wasi-symlinks.js
@@ -62,7 +62,6 @@ if (process.argv[2] === 'wasi-child') {
const opts = { env: { ...process.env, NODE_DEBUG_NATIVE: 'wasi' } };
const child = cp.spawnSync(process.execPath, [
'--experimental-wasi-unstable-preview1',
- '--experimental-wasm-bigint',
__filename,
'wasi-child',
options.test,
diff --git a/test/wasi/test-wasi.js b/test/wasi/test-wasi.js
index 083cf1b17b..261d7928ec 100644
--- a/test/wasi/test-wasi.js
+++ b/test/wasi/test-wasi.js
@@ -51,7 +51,6 @@ if (process.argv[2] === 'wasi-child') {
const child = cp.spawnSync(process.execPath, [
'--experimental-wasi-unstable-preview1',
- '--experimental-wasm-bigint',
__filename,
'wasi-child',
options.test