diff options
| author | Evan Lucas <evanlucas@me.com> | 2017-07-11 19:05:39 -0500 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2017-08-16 00:37:51 -0700 |
| commit | dc05da730f121a4aa706408a65ed254638fb4227 (patch) | |
| tree | 0ae7f3df2f85803a67ada6a8db1d0109e9541634 | |
| parent | 70f2299c1e6e9ef857aeb050e6ec047ed2440249 (diff) | |
| download | node-new-dc05da730f121a4aa706408a65ed254638fb4227.tar.gz | |
build: codesign tarball binary on macOS
Previously, we were signing the binary that was released in the .pkg,
but not the binary released in the tarball.
PR-URL: https://github.com/nodejs/node/pull/14179
Fixes: https://github.com/nodejs/node/issues/11936
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | Makefile | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -617,6 +617,9 @@ $(BINARYTAR): release-only cp README.md $(BINARYNAME) cp LICENSE $(BINARYNAME) cp CHANGELOG.md $(BINARYNAME) +ifeq ($(OSTYPE),darwin) + SIGN="$(CODESIGN_CERT)" PKGDIR="$(BINARYNAME)" bash tools/osx-codesign.sh +endif tar -cf $(BINARYNAME).tar $(BINARYNAME) rm -rf $(BINARYNAME) gzip -c -f -9 $(BINARYNAME).tar > $(BINARYNAME).tar.gz |