diff options
| author | Nikolai Vavilov <vvnicholas@gmail.com> | 2017-11-20 16:56:33 +0200 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2018-02-12 19:28:22 -0500 |
| commit | d85840dd8fbeffcb31620b39db8f770f84297e18 (patch) | |
| tree | ac4aa4aefbf67a30f5781f13bcead1fdf95318f2 | |
| parent | ffc1444117a35fd8572edc4c4aad0e093322f9a8 (diff) | |
| download | node-new-d85840dd8fbeffcb31620b39db8f770f84297e18.tar.gz | |
doc: require CI status indicator in PRs
Commits are often landed despite failing on one or more CI platforms.
Having a CI status indicator in the PR should make this less likely to
happen.
PR-URL: https://github.com/nodejs/node/pull/17151
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index ce43bc208f..9b8140bfea 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -142,6 +142,7 @@ test should *fail* before the change, and *pass* after the change. All pull requests that modify executable code should be subjected to continuous integration tests on the [project CI server](https://ci.nodejs.org/). +The pull request should have a CI status indicator if possible. #### Useful CI Jobs |