summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorweewey <chuayewwee@gmail.com>2017-04-26 22:20:35 +0800
committerEvan Lucas <evanlucas@me.com>2017-05-02 15:22:46 -0500
commit3e9e6afd8a9d5fdbc12a829298cf28bfc976bf6a (patch)
treea67cb4fdcfab0b3c81bc6e25aab5bcfa3e258b46
parent75e053be39726e78af7f63b8e413c1c06fc32e13 (diff)
downloadnode-new-3e9e6afd8a9d5fdbc12a829298cf28bfc976bf6a.tar.gz
test: use common.mustCall in test-https-strict
PR-URL: https://github.com/nodejs/node/pull/12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
-rw-r--r--test/parallel/test-https-strict.js10
1 files changed, 2 insertions, 8 deletions
diff --git a/test/parallel/test-https-strict.js b/test/parallel/test-https-strict.js
index 9c650dc6ab..8c8fa0e5fd 100644
--- a/test/parallel/test-https-strict.js
+++ b/test/parallel/test-https-strict.js
@@ -70,8 +70,6 @@ server2.listen(0, listening());
server3.listen(0, listening());
const responseErrors = {};
-let expectResponseCount = 0;
-let responseCount = 0;
let pending = 0;
@@ -126,17 +124,14 @@ function makeReq(path, port, error, host, ca) {
options.headers = { host: host };
}
const req = https.get(options);
- expectResponseCount++;
const server = port === server1.address().port ? server1 :
port === server2.address().port ? server2 :
port === server3.address().port ? server3 :
null;
-
if (!server) throw new Error('invalid port: ' + port);
server.expectCount++;
- req.on('response', (res) => {
- responseCount++;
+ req.on('response', common.mustCall((res) => {
assert.strictEqual(res.connection.authorizationError, error);
responseErrors[path] = res.connection.authorizationError;
pending--;
@@ -146,7 +141,7 @@ function makeReq(path, port, error, host, ca) {
server3.close();
}
res.resume();
- });
+ }));
}
function allListening() {
@@ -199,5 +194,4 @@ process.on('exit', () => {
assert.strictEqual(server1.requests.length, server1.expectCount);
assert.strictEqual(server2.requests.length, server2.expectCount);
assert.strictEqual(server3.requests.length, server3.expectCount);
- assert.strictEqual(responseCount, expectResponseCount);
});