diff options
| author | Brian White <mscdex@mscdex.net> | 2017-04-15 00:42:25 -0400 |
|---|---|---|
| committer | Evan Lucas <evanlucas@me.com> | 2017-05-02 15:22:44 -0500 |
| commit | 60daaaeff2c325156789c687e3efc7b59b02ee78 (patch) | |
| tree | 4496eec0fea45c46410d7c98182bb5a46dc286a9 | |
| parent | d154aafe185fb03598a0c8416141e72b7c37e992 (diff) | |
| download | node-new-60daaaeff2c325156789c687e3efc7b59b02ee78.tar.gz | |
url: always show password for URL instances
This matches browser behavior.
PR-URL: https://github.com/nodejs/node/pull/12420
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
| -rw-r--r-- | lib/internal/url.js | 5 | ||||
| -rw-r--r-- | test/parallel/test-whatwg-url-inspect.js | 2 |
2 files changed, 2 insertions, 5 deletions
diff --git a/lib/internal/url.js b/lib/internal/url.js index 9929c006d5..3fabf09beb 100644 --- a/lib/internal/url.js +++ b/lib/internal/url.js @@ -215,8 +215,6 @@ class URL { throw new TypeError('Value of `this` is not a URL'); } - const ctx = this[context]; - if (typeof depth === 'number' && depth < 0) return opts.stylize('[Object]', 'special'); @@ -230,8 +228,7 @@ class URL { obj.origin = this.origin; obj.protocol = this.protocol; obj.username = this.username; - obj.password = (opts.showHidden || ctx.password === '') ? - this.password : '--------'; + obj.password = this.password; obj.host = this.host; obj.hostname = this.hostname; obj.port = this.port; diff --git a/test/parallel/test-whatwg-url-inspect.js b/test/parallel/test-whatwg-url-inspect.js index a8a59b7787..8db1a20e5b 100644 --- a/test/parallel/test-whatwg-url-inspect.js +++ b/test/parallel/test-whatwg-url-inspect.js @@ -21,7 +21,7 @@ assert.strictEqual( origin: 'https://host.name:8080', protocol: 'https:', username: 'username', - password: '--------', + password: 'password', host: 'host.name:8080', hostname: 'host.name', port: '8080', |