diff options
author | Steven R. Loomis <srloomis@us.ibm.com> | 2019-09-30 11:17:49 -0700 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-03 15:21:26 -0700 |
commit | 1a25e901b7c380929f0d08599f49dd77897a627f (patch) | |
tree | 3fdac9d1df5970cf8870bf5a9a5ae1cb45fa890a /BUILDING.md | |
parent | a71fb978a40b5251fdb012bab5e03598d5397a10 (diff) | |
download | node-new-1a25e901b7c380929f0d08599f49dd77897a627f.tar.gz |
tools: support full-icu by default
Instead of an English-only icudt64l.dat in the repo,
we now have icudt64l.dat.gz with all locales.
- updated READMEs and docs
- shrinker now copies source, and compresses (bzip2) the ICU data file
- configure expects deps/icu-small to be full ICU with a full
compressed data file
Fixes: https://github.com/nodejs/node/issues/19214
Co-Authored-By: Richard Lau <riclau@uk.ibm.com>
Co-Authored-By: Jan Olaf Krems <jan.krems@gmail.com>
Co-Authored-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/29522
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Diffstat (limited to 'BUILDING.md')
-rw-r--r-- | BUILDING.md | 47 |
1 files changed, 29 insertions, 18 deletions
diff --git a/BUILDING.md b/BUILDING.md index 0e0379265f..aadba46020 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -35,21 +35,23 @@ file a new issue. * [Building Node.js](#building-nodejs-1) * [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os) * [`Intl` (ECMA-402) support](#intl-ecma-402-support) - * [Default: `small-icu` (English only) support](#default-small-icu-english-only-support) * [Build with full ICU support (all locales supported by ICU)](#build-with-full-icu-support-all-locales-supported-by-icu) * [Unix/macOS](#unixmacos) * [Windows](#windows-1) - * [Building without Intl support](#building-without-intl-support) + * [Trimmed: `small-icu` (English only) support](#trimmed-small-icu-english-only-support) * [Unix/macOS](#unixmacos-1) * [Windows](#windows-2) - * [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacOS-only) - * [Build with a specific ICU](#build-with-a-specific-icu) + * [Building without Intl support](#building-without-intl-support) * [Unix/macOS](#unixmacos-2) * [Windows](#windows-3) + * [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacOS-only) + * [Build with a specific ICU](#build-with-a-specific-icu) + * [Unix/macOS](#unixmacos-3) + * [Windows](#windows-4) * [Building Node.js with FIPS-compliant OpenSSL](#building-nodejs-with-fips-compliant-openssl) * [Building Node.js with external core modules](#building-nodejs-with-external-core-modules) - * [Unix/macOS](#unixmacos-3) - * [Windows](#windows-4) + * [Unix/macOS](#unixmacos-4) + * [Windows](#windows-5) * [Note for downstream distributors of Node.js](#note-for-downstream-distributors-of-nodejs) ## Supported platforms @@ -598,31 +600,40 @@ $ make ## `Intl` (ECMA-402) support [Intl](https://github.com/nodejs/node/blob/master/doc/api/intl.md) support is -enabled by default, with English data only. +enabled by default. -### Default: `small-icu` (English only) support +### Build with full ICU support (all locales supported by ICU) -By default, only English data is included, but -the full `Intl` (ECMA-402) APIs. It does not need to download -any dependencies to function. You can add full -data at runtime. +This is the default option. -### Build with full ICU support (all locales supported by ICU) +#### Unix/macOS -With the `--download=all`, this may download ICU if you don't have an -ICU in `deps/icu`. (The embedded `small-icu` included in the default -Node.js source does not include all locales.) +```console +$ ./configure --with-intl=full-icu +``` + +#### Windows + +```console +> .\vcbuild full-icu +``` + +### Trimmed: `small-icu` (English only) support + + In this configuration, only English data is included, but +the full `Intl` (ECMA-402) APIs. It does not need to download +any dependencies to function. You can add full data at runtime. #### Unix/macOS ```console -$ ./configure --with-intl=full-icu --download=all +$ ./configure --with-intl=small-icu ``` #### Windows ```console -> .\vcbuild full-icu download-all +> .\vcbuild small-icu ``` ### Building without Intl support |