diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-03-06 13:44:11 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-03-08 14:38:35 -0800 |
| commit | ed465eb595452b9fd0e9696de5d1a6f7790b9985 (patch) | |
| tree | cdd06fe50491e91ee81a2f094fdeed040dcac2bf /COLLABORATOR_GUIDE.md | |
| parent | 4fe66a3c7f32ae2efda64603eba111c42014b35b (diff) | |
| download | node-new-ed465eb595452b9fd0e9696de5d1a6f7790b9985.tar.gz | |
doc: edit "Involving the TSC"
Edit the "Involving the TSC" section of the Collaborator Guide to reduce
passive voice, make things concise, etc.
PR-URL: https://github.com/nodejs/node/pull/26481
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 608dd347e5..a14aaaa049 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -374,13 +374,12 @@ deprecation level of an API. ### Involving the TSC Collaborators may opt to elevate pull requests or issues to the [TSC][]. -This should be done where a pull request: +Do this if a pull request or issue: - is labeled `semver-major`, or - has a significant impact on the codebase, or -- is inherently controversial, or -- has failed to reach consensus amongst the Collaborators who are - actively participating in the discussion. +- is controversial, or +- is at an impasse among Collaborators who are participating in the discussion. Assign the `tsc-review` label or @-mention the `@nodejs/tsc` GitHub team if you want to elevate an issue to the [TSC][]. |