diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-06-20 13:22:34 -0600 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-23 07:07:09 -0700 |
| commit | 6f15029b4428acaafcfa96390eed989d2a318a6c (patch) | |
| tree | 030b938a645173fb6c18b65ce89ac096a5124c1f /CPP_STYLE_GUIDE.md | |
| parent | dc5eb64ac8dbe9d50f02c90f8e6948270216a99d (diff) | |
| download | node-new-6f15029b4428acaafcfa96390eed989d2a318a6c.tar.gz | |
doc: remove "note that" from CPP_STYLE_GUIDE.md
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/16
PR-URL: https://github.com/nodejs/node/pull/28329
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'CPP_STYLE_GUIDE.md')
| -rw-r--r-- | CPP_STYLE_GUIDE.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CPP_STYLE_GUIDE.md b/CPP_STYLE_GUIDE.md index b31055ffbd..d624156b97 100644 --- a/CPP_STYLE_GUIDE.md +++ b/CPP_STYLE_GUIDE.md @@ -326,7 +326,7 @@ When there is a need to throw errors from a C++ binding method, try to return the data necessary for constructing the errors to JavaScript, then construct and throw the errors [using `lib/internal/errors.js`][errors]. -Note that in general, type-checks on arguments should be done in JavaScript +In general, type-checks on arguments should be done in JavaScript before the arguments are passed into C++. Then in the C++ binding, simply using `CHECK` assertions to guard against invalid arguments should be enough. |