diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-06-13 11:59:15 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-06-17 05:32:15 +0200 |
| commit | b456bbcc6d0598ed3a8fa5edd05d5d71b372eab7 (patch) | |
| tree | 49edd8dd2dfeff0aedc6b1e40bf35e1393a43bce /Makefile | |
| parent | 370873c59e811132bfd60ccea12caaad869daac7 (diff) | |
| download | node-new-b456bbcc6d0598ed3a8fa5edd05d5d71b372eab7.tar.gz | |
build: guard test-doc recipe with node_use_openssl
Currently, when configuring --without-ssl the test-doc target fails with
the following error:
/node/test/common/index.js:707
const crashOnUnhandledRejection = (err) => { throw err; };
^
Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at Object.assertCrypto (internal/util.js:97:11)
at https.js:26:26
at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
...
at /node/tools/doc/versions.js:7:19
at new Promise (<anonymous>)
at getUrl (/node/tools/doc/versions.js:6:10)
Command: out/Release/node /node/test/doctool/test-doctool-html.js
[00:02|% 100|+ 3|- 1]: Done
make: *** [test-doc] Error 1
This commit guards the test-doc recipe to not run if node was
configured without crypto support.
PR-URL: https://github.com/nodejs/node/pull/28199
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 8 |
1 files changed, 6 insertions, 2 deletions
@@ -586,8 +586,12 @@ test-hash-seed: all .PHONY: test-doc test-doc: doc-only ## Builds, lints, and verifies the docs. - $(MAKE) lint - $(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC) + @if [ "$(shell $(node_use_openssl))" != "true" ]; then \ + echo "Skipping test-doc (no crypto)"; \ + else \ + $(MAKE) lint; \ + $(PYTHON) tools/test.py $(PARALLEL_ARGS) $(CI_DOC); \ + fi test-known-issues: all $(PYTHON) tools/test.py $(PARALLEL_ARGS) known_issues |