diff options
| author | Michael Dawson <michael_dawson@ca.ibm.com> | 2019-01-22 16:26:28 -0500 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-01-29 08:18:06 +0100 |
| commit | c06653efdbee30cc3db5814af78ce2d824da2413 (patch) | |
| tree | 1456a401acbf0b078cb1bb07beb312596792fefe /Makefile | |
| parent | 78982389ce9265f5f65cd9e8a192e05389506927 (diff) | |
| download | node-new-c06653efdbee30cc3db5814af78ce2d824da2413.tar.gz | |
test: enable marking of failing coverage tests
Enable marking of coverage tests so that we can
allow some tests to fail without blocking the generation
of coverage data. This will later allow us to
fail the coverage job if other kinds of errors occur and
to capture which tests we believe are not running properly
with coverage enabled.
PR-URL: https://github.com/nodejs/node/pull/25671
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -226,7 +226,8 @@ coverage-test: coverage-build $(RM) out/$(BUILDTYPE)/obj.target/node_lib/gen/*.gcda $(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/*.gcda $(RM) out/$(BUILDTYPE)/obj.target/node_lib/src/tracing/*.gcda - -NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage $(MAKE) $(COVTESTS) + -NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage \ + TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) $(COVTESTS) $(MAKE) coverage-report-js -(cd out && "../gcovr/scripts/gcovr" --gcov-exclude='.*deps' \ --gcov-exclude='.*usr' -v -r Release/obj.target \ @@ -277,7 +278,7 @@ coverage-run-js: $(RM) -r out/$(BUILDTYPE)/.coverage $(MAKE) coverage-build-js -NODE_V8_COVERAGE=out/$(BUILDTYPE)/.coverage CI_SKIP_TESTS=$(COV_SKIP_TESTS) \ - $(MAKE) jstest + TEST_CI_ARGS="$(TEST_CI_ARGS) --type=coverage" $(MAKE) jstest $(MAKE) coverage-report-js .PHONY: test |