diff options
| author | Rich Trott <rtrott@gmail.com> | 2019-04-04 10:49:29 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-04-06 22:37:47 -0700 |
| commit | 77dee25efd2fb114a56e83a165a97fef22c68316 (patch) | |
| tree | b810748c1a03ee70fc32e8f84b31fdc3b4008620 /benchmark | |
| parent | 21b739fb69850763f5d18ef864f592cc9a843de4 (diff) | |
| download | node-new-77dee25efd2fb114a56e83a165a97fef22c68316.tar.gz | |
benchmark: remove deprecated argument
The benchmarks for dns.lookup() include calling it with an empty
hostname which results in a deprecation warning. This benchmark seems to
be subject to some odd side effects (see Ref below) and we probably
generally don't want to benchmark deprecated things by default anyway.
Remove the deprecated value from the default list. Bonus is that this
will speed up the benchmark.
Refs: https://github.com/nodejs/node/pull/27081#issuecomment-479981874
PR-URL: https://github.com/nodejs/node/pull/27091
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'benchmark')
| -rw-r--r-- | benchmark/dns/lookup.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/benchmark/dns/lookup.js b/benchmark/dns/lookup.js index 3cc228c566..164e490bd3 100644 --- a/benchmark/dns/lookup.js +++ b/benchmark/dns/lookup.js @@ -4,7 +4,7 @@ const common = require('../common.js'); const lookup = require('dns').lookup; const bench = common.createBenchmark(main, { - name: ['', '127.0.0.1', '::1'], + name: ['127.0.0.1', '::1'], all: ['true', 'false'], n: [5e6] }); |