diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-04 11:36:41 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-04-06 12:04:36 +0800 |
| commit | de230555369087282213d337ecc1c315fbb74230 (patch) | |
| tree | 19e10179deff9ba47dac546af566e09a4a3f9a66 /benchmark | |
| parent | 864860e9f3d4eed0b0b81af55197d7e525ea6306 (diff) | |
| download | node-new-de230555369087282213d337ecc1c315fbb74230.tar.gz | |
lib: remove `env: node` in eslint config for lib files
This patch removes the redundant `require-globals` custom
eslint rule by removing `env: node` in the eslint config
and whitelist the globals that can be accessed in native
modules instead of black listing them. This makes sense
for our `lib/` files because here we are creating the
Node.js environment instead of running in a normal user
land Node.js environment.
PR-URL: https://github.com/nodejs/node/pull/27082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'benchmark')
| -rw-r--r-- | benchmark/.eslintrc.yaml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/benchmark/.eslintrc.yaml b/benchmark/.eslintrc.yaml index f8585fd706..7de962dc90 100644 --- a/benchmark/.eslintrc.yaml +++ b/benchmark/.eslintrc.yaml @@ -1,5 +1,9 @@ ## Benchmark-specific linter rules +env: + node: true + es6: true + rules: comma-dangle: - error |