diff options
| author | Refael Ackermann <refack@gmail.com> | 2018-08-29 08:29:55 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2018-12-06 15:25:18 +0100 |
| commit | 5620727f30e5867671d9ec03b77a36fb7ca7ff4f (patch) | |
| tree | d1aa50e89bb83e246f787df88a7fea6dbf9df24f /common.gypi | |
| parent | 23603447adfd0f1109f664ca5755b67b228da05c (diff) | |
| download | node-new-5620727f30e5867671d9ec03b77a36fb7ca7ff4f.tar.gz | |
deps: sync V8 gypfiles with 7.1
Enable v8_enable_embedded_builtins.
Reorder conditions proccessing for `run_mksnapshot`.
deps,v8: link with `atomic` for platforms lacking CAS
Fixes: https://github.com/nodejs/node-v8/issues/81
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 41 |
1 files changed, 34 insertions, 7 deletions
diff --git a/common.gypi b/common.gypi index bf80d4b4b4..cfedbe4be8 100644 --- a/common.gypi +++ b/common.gypi @@ -29,26 +29,53 @@ 'openssl_fips%': '', + # Some STL containers (e.g. std::vector) do not preserve ABI compatibility + # between debug and non-debug mode. + 'disable_glibcxx_debug': 1, + + # Don't use ICU data file (icudtl.dat) from V8, we use our own. + 'icu_use_data_file_flag%': 0, + # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.0', + 'v8_embedder_string': '-node.1', + + ##### V8 defaults for Node.js ##### + + # Old time default, now explicitly stated. + 'v8_use_snapshot': 'true', + + # Refs: https://github.com/nodejs/node/issues/23122 + # Refs: https://github.com/nodejs/node/issues/23167 + # Enable compiler warnings when using V8_DEPRECATED apis. + 'v8_deprecation_warnings': 1, + # Enable compiler warnings when using V8_DEPRECATE_SOON apis. + 'v8_imminent_deprecation_warnings': 1, # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, # Don't bake anything extra into the snapshot. - 'v8_use_external_startup_data%': 0, + 'v8_use_external_startup_data': 0, + + # https://github.com/nodejs/node/pull/22920/files#r222779926 + 'v8_enable_handle_zapping': 0, # Disable V8 untrusted code mitigations. # See https://github.com/v8/v8/wiki/Untrusted-code-mitigations 'v8_untrusted_code_mitigations': 'false', - # Some STL containers (e.g. std::vector) do not preserve ABI compatibility - # between debug and non-debug mode. - 'disable_glibcxx_debug': 1, + # Still WIP in V8 7.1 + 'v8_enable_pointer_compression': 'false', - # Don't use ICU data file (icudtl.dat) from V8, we use our own. - 'icu_use_data_file_flag%': 0, + # New in V8 7.1 + 'v8_enable_embedded_builtins': 'true', + + # This is more of a V8 dev setting + # https://github.com/nodejs/node/pull/22920/files#r222779926 + 'v8_enable_fast_mksnapshot': 0, + + ##### end V8 defaults ##### 'conditions': [ ['target_arch=="arm64"', { |