diff options
| author | James M Snell <jasnell@gmail.com> | 2018-08-23 10:16:00 -0700 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-09-19 11:07:01 +0200 |
| commit | 9d71e6a6071134789a30471302d9735250dea96c (patch) | |
| tree | 67a21cf09e3f5e3dd152ba22717ace87860e2f23 /configure.py | |
| parent | 6e746f1a55e5d94f1a8330d3436a64ed8d6f639b (diff) | |
| download | node-new-9d71e6a6071134789a30471302d9735250dea96c.tar.gz | |
src: deprecate global COUNTER_* and remove perfctr
To support Performance Counters on Windows, a number of
global `COUNTER_` methods were added that are undocumented
and really only intended to be used internally by Node.js.
Unfortunately, the perfctr support apparently hasn't even
worked for quite a while and no one has even complained.
This removes the perfctr support and replaces the global
functions with deprecated non-ops for now, with the intent
of removing those outright in the next major release cycle.
PR-URL: https://github.com/nodejs/node/pull/22485
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 18 |
1 files changed, 0 insertions, 18 deletions
diff --git a/configure.py b/configure.py index da696a92b4..349dca827e 100755 --- a/configure.py +++ b/configure.py @@ -455,11 +455,6 @@ http2_optgroup.add_option('--debug-nghttp2', parser.add_option_group(http2_optgroup) -parser.add_option('--with-perfctr', - action='store_true', - dest='with_perfctr', - help='build with performance counters (default is true on Windows)') - parser.add_option('--without-dtrace', action='store_true', dest='without_dtrace', @@ -475,11 +470,6 @@ parser.add_option('--without-npm', dest='without_npm', help='do not install the bundled npm (package manager)') -parser.add_option('--without-perfctr', - action='store_true', - dest='without_perfctr', - help='build without performance counters') - # Dummy option for backwards compatibility parser.add_option('--with-snapshot', action='store_true', @@ -1018,14 +1008,6 @@ def configure_node(o): else: o['variables']['node_use_etw'] = 'false' - # By default, enable Performance counters on Windows. - if flavor == 'win': - o['variables']['node_use_perfctr'] = b(not options.without_perfctr) - elif options.with_perfctr: - raise Exception('Performance counter is only supported on Windows.') - else: - o['variables']['node_use_perfctr'] = 'false' - o['variables']['node_with_ltcg'] = b(options.with_ltcg) if flavor != 'win' and options.with_ltcg: raise Exception('Link Time Code Generation is only supported on Windows.') |