diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-12 02:38:14 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-17 10:02:05 +0800 |
| commit | 28d3f1963a98ce157b360c0a3ba70fb8e1f73f60 (patch) | |
| tree | d5b6e31c9564ad5ba9459ce10843d4273c52d8be /configure.py | |
| parent | b6e41f06029912360ad07614c7ddd2ffcfeed2ca (diff) | |
| download | node-new-28d3f1963a98ce157b360c0a3ba70fb8e1f73f60.tar.gz | |
build: turn on custom V8 snapshot by default
This patch re-enables custom V8 snapshot integration. Also renames
the experimental configure switch from `--with-node-snapshot`
to `--without-node-snapshot` to be consistent with`--without-snapshot`
which is used for the default V8 snapshot.
PR-URL: https://github.com/nodejs/node/pull/28181
Refs: https://github.com/nodejs/node/pull/27365
Refs: https://github.com/nodejs/node/issues/17058
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/configure.py b/configure.py index 9d9f0aec0b..b1a04742f0 100755 --- a/configure.py +++ b/configure.py @@ -421,10 +421,10 @@ parser.add_option('--with-ltcg', dest='with_ltcg', help='Use Link Time Code Generation. This feature is only available on Windows.') -parser.add_option('--with-node-snapshot', +parser.add_option('--without-node-snapshot', action='store_true', - dest='with_node_snapshot', - help='Turn on V8 snapshot integration. Currently experimental.') + dest='without_node_snapshot', + help='Turn off V8 snapshot integration. Currently experimental.') intl_optgroup.add_option('--download', action='store', @@ -942,11 +942,9 @@ def configure_node(o): o['variables']['want_separate_host_toolset'] = int( cross_compiling and want_snapshots) - if options.with_node_snapshot: - o['variables']['node_use_node_snapshot'] = 'true' + if not options.without_node_snapshot: + o['variables']['node_use_node_snapshot'] = b(not cross_compiling) else: - # Default to false for now. - # TODO(joyeecheung): enable it once we fix the hashseed uniqueness o['variables']['node_use_node_snapshot'] = 'false' if target_arch == 'arm': |