diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-02-28 08:35:03 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-03-02 14:01:47 +0100 |
| commit | 99797cc9cd2ead9d25330b263fca808477d55621 (patch) | |
| tree | 5855aa4159754a0aa08d75ca3e6b1ec4d99c8b5c /configure.py | |
| parent | f65b4afaea14446c4b313595c03b737ab710c124 (diff) | |
| download | node-new-99797cc9cd2ead9d25330b263fca808477d55621.tar.gz | |
build: make 'floating patch' message informational
Downgrade the 'Using floating patch' message that is emitted
when a local patch is applied to the bundled ICU from a warning
to a notice. There isn't anything the user can or should do so
warning isn't appropriate. Instead of angry yellow use soothing green.
Fixes: https://github.com/nodejs/node/issues/26346
PR-URL: https://github.com/nodejs/node/pull/26349
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/configure.py b/configure.py index ac6b3d4788..cd74f23a6c 100755 --- a/configure.py +++ b/configure.py @@ -585,6 +585,10 @@ def warn(msg): # track if warnings occurred warn.warned = False +def info(msg): + prefix = '\033[1m\033[32mINFO\033[0m' if os.isatty(1) else 'INFO' + print('%s: %s' % (prefix, msg)) + def print_verbose(x): if not options.verbose: return @@ -1232,7 +1236,7 @@ def glob_to_var(dir_base, dir_sub, patch_dir): patchfile = '%s/%s/%s' % (dir_base, patch_dir, file) if os.path.isfile(patchfile): srcfile = '%s/%s' % (patch_dir, file) - warn('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) + info('Using floating patch "%s" from "%s"' % (patchfile, dir_base)) list.append(srcfile) break return list |