diff options
| author | Bert Belder <bertbelder@gmail.com> | 2010-11-24 23:51:32 +0100 |
|---|---|---|
| committer | Bert Belder <bertbelder@gmail.com> | 2010-12-20 23:51:08 +0100 |
| commit | 9a9edb0e8e6120b3b8a3868d0c44577111dd1857 (patch) | |
| tree | 84a915fe26220fde421d4cf0ea4e9c3f322cd4e2 /deps/v8/src | |
| parent | 3216f08b6d9b24ed25227e2b7da9e435f263cff6 (diff) | |
| download | node-new-9a9edb0e8e6120b3b8a3868d0c44577111dd1857.tar.gz | |
Performance-killing bug workaround for V8 on mingw
When V8 on mingw generates a _compiled_ call stub for an external api callback, it fucks up the stack.
It doesn't set the stack pointers properly. Could be due to subtly different calling conventions?
This patch disables the simple_api_call optimization. It hurts performance.
Diffstat (limited to 'deps/v8/src')
| -rw-r--r-- | deps/v8/src/stub-cache.h | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/deps/v8/src/stub-cache.h b/deps/v8/src/stub-cache.h index a7829a600e..523f4aa9b2 100644 --- a/deps/v8/src/stub-cache.h +++ b/deps/v8/src/stub-cache.h @@ -762,6 +762,11 @@ class CallOptimization BASE_EMBEDDED { } bool is_simple_api_call() const { + // As of V8 2.6.8 simple api call optimization causes segfaults on MINGW + // Disable it until this gets resolved +#ifdef __MINGW32__ + return false; +#endif return is_simple_api_call_; } |