diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2012-07-12 15:42:44 +0200 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2012-07-12 16:17:25 +0200 |
| commit | 202df30aabc78fa571cf77ad93146b3c4d99fc6e (patch) | |
| tree | 8c582104ae205ec44fab6aa8513e056d6ed26279 /deps | |
| parent | d2e40f66cc21d38d1c887b45143b6b9de468b903 (diff) | |
| download | node-new-202df30aabc78fa571cf77ad93146b3c4d99fc6e.tar.gz | |
build: disable unsafe optimizations
Compile at -O2 and disable optimizations that trigger gcc bugs.
Some people still reported mksnapshot crashes after commit b40f813 ("build: fix
spurious mksnapshot crashes for good" - so much for that).
Average performance of the -O2 binary is on par with the -O3 binary. Variance
on the http_simple bytes/8 benchmark appears to be slightly greater but small
enough that the possibly of it being noise cannot be excluded.
The new binary very slightly but consistently outperforms the -O3 binary (by
about 0.5%) on the mostly CPU-bound bytes/102400 benchmark. That could be an
artifact of the system I benchmarked it on, a Core 2 Duo with a puny 32 kB of
L1 instruction cache. The smaller binary seems to play nicer with the cache.
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/build/common.gypi | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/deps/v8/build/common.gypi b/deps/v8/build/common.gypi index 2d8dc11b70..1609197876 100644 --- a/deps/v8/build/common.gypi +++ b/deps/v8/build/common.gypi @@ -332,10 +332,6 @@ 'conditions': [ ['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd" \ or OS=="android"', { - 'cflags!': [ - '-O2', - '-Os', - ], 'cflags': [ '-fdata-sections', '-ffunction-sections', |