diff options
| author | Michaël Zasso <targos@protonmail.com> | 2021-07-07 12:02:18 +0200 |
|---|---|---|
| committer | Richard Lau <rlau@redhat.com> | 2021-07-23 11:41:16 +0100 |
| commit | 15b91fa3fac3e5a3a65f83ad9a5f312157ec7fd2 (patch) | |
| tree | d2e929d4531cf12a53b815711fab0f2257f8b376 /deps | |
| parent | 8046daf09ff3e8b436477f0179d25ac6d1cf4744 (diff) | |
| download | node-new-15b91fa3fac3e5a3a65f83ad9a5f312157ec7fd2.tar.gz | |
deps: V8: backport 895949419186
Original commit message:
Add -Wno-string-concatenation to test/cctest:cctest_sources
v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation.
Bug: chromium:1114873
Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69625}
Refs: https://github.com/v8/v8/commit/8959494191869ff483927916f9f46eb419784f07
PR-URL: https://github.com/nodejs/node/pull/39245
Refs: https://github.com/nodejs/build/issues/2696
Reviewed-By: Richard Lau <rlau@redhat.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/test/cctest/BUILD.gn | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/deps/v8/test/cctest/BUILD.gn b/deps/v8/test/cctest/BUILD.gn index 1a52707345..8acd2e50f3 100644 --- a/deps/v8/test/cctest/BUILD.gn +++ b/deps/v8/test/cctest/BUILD.gn @@ -63,6 +63,12 @@ v8_header_set("cctest_headers") { ] } +config("cctest_sources_config") { + if (is_clang) { + cflags = [ "-Wno-string-concatenation" ] + } +} + v8_source_set("cctest_sources") { testonly = true @@ -376,6 +382,7 @@ v8_source_set("cctest_sources") { configs = [ "../..:external_config", "../..:internal_config_base", + ":cctest_sources_config", ] public_deps = [ |