summaryrefslogtreecommitdiff
path: root/deps
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-03-17 16:59:54 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2018-04-10 00:36:26 +0200
commit49fd9c63d21c8c42a110996a6a68bf1fdcee12b4 (patch)
tree1ce3f7768a33e36ed6807f27d470407563f8275c /deps
parentcc6abc6e84b96fd5f1c4123066eba93ddb637e60 (diff)
downloadnode-new-49fd9c63d21c8c42a110996a6a68bf1fdcee12b4.tar.gz
zlib: use `.bytesWritten` instead of `.bytesRead`
The introduction of `.bytesRead` to zlib streams was unfortunate, because other streams in Node.js core use the exact opposite naming of `.bytesRead` and `.bytesWritten`. While one could see how the original naming makes sense in a `Transform` stream context, we should try to work towards more consistent APIs in core for these things. This introduces `zlib.bytesWritten` and documentation-only deprecates `zlib.bytesRead`. PR-URL: https://github.com/nodejs/node/pull/19414 Refs: https://github.com/nodejs/node/issues/8874 Refs: https://github.com/nodejs/node/pull/13088 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'deps')
0 files changed, 0 insertions, 0 deletions