diff options
| author | Timothy Gu <timothygu99@gmail.com> | 2017-09-29 22:15:24 -0700 |
|---|---|---|
| committer | Timothy Gu <timothygu99@gmail.com> | 2017-10-04 12:27:08 -0700 |
| commit | 806857712f76398a786874d77aa65e2f3cbf7dab (patch) | |
| tree | fd11121ba67c9ddae36991bab3cb8b50d8e946e9 /doc/api/domain.md | |
| parent | a3cd8ed1681d39e9ce65b90f52ee6d67fc7d3fdc (diff) | |
| download | node-new-806857712f76398a786874d77aa65e2f3cbf7dab.tar.gz | |
src: do not add .domain to promises in VM contexts
The promises are still tracked, and their handlers will still execute in
the correct domain. The creation domain is simply hidden.
PR-URL: https://github.com/nodejs/node/pull/15695
Fixes: https://github.com/nodejs/node/issues/15673
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'doc/api/domain.md')
| -rw-r--r-- | doc/api/domain.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/doc/api/domain.md b/doc/api/domain.md index 285378c3bd..30e93e2bea 100644 --- a/doc/api/domain.md +++ b/doc/api/domain.md @@ -1,6 +1,12 @@ # Domain <!-- YAML changes: + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/REPLACEME + description: Any `Promise`s created in VM contexts no longer have a + `.domain` property. Their handlers are still executed in the + proper domain, however, and `Promise`s created in the main + context still possess a `.domain` property. - version: v8.0.0 pr-url: https://github.com/nodejs/node/pull/12489 description: Handlers for `Promise`s are now invoked in the domain in which |