diff options
| author | Alba Mendez <me@alba.sh> | 2020-04-27 03:15:07 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2020-04-28 19:20:19 +0200 |
| commit | ee9280a02a4f8810a2d4fd409d08266ce95f2184 (patch) | |
| tree | 7e91d971e6477b49f83c9820a7f60ff44d25c7cd /doc/api | |
| parent | 8e956f450ad0ebd2b06235620eaaa00ead3af375 (diff) | |
| download | node-new-ee9280a02a4f8810a2d4fd409d08266ce95f2184.tar.gz | |
http2,doc: minor fixes
Some small fixes on HTTP/2 and its documentation:
- Add a note that, on server streams, it's not necessary
to start data flow.
- Set EOF flag if we have marked all data for sending:
there's no need to wait until the queue is
actually empty (and send a separate, empty DATA).
(Note that, even with this change, a separate DATA
frame will always be sent, because the streams
layer waits until data has been flushed before
dispatching EOF)
PR-URL: https://github.com/nodejs/node/pull/28044
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'doc/api')
| -rw-r--r-- | doc/api/http2.md | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/doc/api/http2.md b/doc/api/http2.md index c4365f4e20..6f3b70be3a 100644 --- a/doc/api/http2.md +++ b/doc/api/http2.md @@ -913,8 +913,9 @@ the value is `undefined`, the stream is not yet ready for use. All [`Http2Stream`][] instances are destroyed either when: * An `RST_STREAM` frame for the stream is received by the connected peer, - and pending data has been read. -* The `http2stream.close()` method is called, and pending data has been read. + and (for client streams only) pending data has been read. +* The `http2stream.close()` method is called, and (for client streams only) + pending data has been read. * The `http2stream.destroy()` or `http2session.destroy()` methods are called. When an `Http2Stream` instance is destroyed, an attempt will be made to send an |