diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-01-20 21:38:24 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-01-24 18:42:01 +0800 |
| commit | 0e7050ec86c1fb3ab5a3fb6c4500cfa42442ae0d (patch) | |
| tree | eb3aa8e05ff0d254c18ba890507750306381dd25 /doc/onboarding.md | |
| parent | a083786c7733b5828102661a04a86884c934950a (diff) | |
| download | node-new-0e7050ec86c1fb3ab5a3fb6c4500cfa42442ae0d.tar.gz | |
doc: improve the instructions of onboarding PR
PR-URL: https://github.com/nodejs/node/pull/18268
Fixes: https://github.com/nodejs/node/issues/18090
Refs: https://github.com/nodejs/TSC/pull/472
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index e67f6638d3..42144e2382 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -199,12 +199,13 @@ onboarding session. * Optionally, include your personal pronouns. * Label your pull request with the `doc` subsystem label. * Run CI on your PR. -* After one or two approvals, land the PR. +* After one or two approvals, land the PR (PRs of this type do not need to wait + for 48/72 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` - metadata! - * [`core-validate-commit`][] helps a lot with this – install and use it if you - can! - * [`node-core-utils`][] fetches the metadata for you. + metadata. + * [`core-validate-commit`][] automates the validation of commit messages. + * [`node-core-utils`][] automates the generation of metadata and the landing + process. See the documentation of [`git-node`][]. ## Final notes @@ -227,6 +228,7 @@ onboarding session. [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md [`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit +[`git-node`]: https://github.com/nodejs/node-core-utils#git-node [`node-core-utils`]: https://github.com/nodejs/node-core-utils [Landing Pull Requests]: https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md#landing-pull-requests [https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0]: https://github.com/nodejs/node/commit/ce986de829457c39257cd205067602e765768fb0 |