diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-05-30 14:23:32 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-06-02 02:25:34 +0200 |
| commit | 77d3f141cf465613f0bcd270c6bd2bcd9c962f92 (patch) | |
| tree | 9718b51e086caf6700558bafadbd931ea9e23b4e /doc/onboarding.md | |
| parent | 923f6ac08f68ba7c28b9e2bd82228104c038e49a (diff) | |
| download | node-new-77d3f141cf465613f0bcd270c6bd2bcd9c962f92.tar.gz | |
doc: add notable-change to onboarding.md exercise
Pull requests that add new Collaborators should be labeled
`notable-change`. Make a note of this in onboarding.md.
PR-URL: https://github.com/nodejs/node/pull/21040
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'doc/onboarding.md')
| -rw-r--r-- | doc/onboarding.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index 1474d24f1d..0748c1be7d 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -211,7 +211,7 @@ needs to be pointed out separately during the onboarding. -1` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. -* Label your pull request with the `doc` subsystem label. +* Label your pull request with the `doc` and `notable-change` labels. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite` CI task. Alternatively, use the usual `node-test-pull-request` CI task and cancel it after the linter and one other |