streams: update .readable/.writable to false

These properties were initially used to determine stream status
back in node v0.8 and earlier. Since streams2 however, these
properties were *always* true, which can be misleading for
example if you are trying to immediately determine whether
a Writable stream is still writable or not (to avoid a "write after
end" exception).

PR-URL: https://github.com/nodejs/node/pull/4083
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>

2 files changed, 3 insertions, 1 deletions

diff --git a/lib/_stream_readable.js b/lib/_stream_readable.js
index 0316a05571..ea36e6ed62 100644
--- a/lib/_stream_readable.js
+++ b/lib/_stream_readable.js
@@ -385,6 +385,7 @@ function onEofChunk(stream, state) {
     }
   }
   state.ended = true;
+  stream.readable = false;
 
   // emit 'readable' now to make sure it gets picked up.
   emitReadable(stream);
@@ -670,7 +671,7 @@ Readable.prototype.on = function(ev, fn) {
     this.resume();
   }
 
-  if (ev === 'readable' && this.readable) {
+  if (ev === 'readable' && !this._readableState.endEmitted) {
     var state = this._readableState;
     if (!state.readableListening) {
       state.readableListening = true;
diff --git a/lib/_stream_writable.js b/lib/_stream_writable.js
index 73f4d9fb3e..10fcae04f5 100644
--- a/lib/_stream_writable.js
+++ b/lib/_stream_writable.js
@@ -483,4 +483,5 @@ function endWritable(stream, state, cb) {
       stream.once('finish', cb);
   }
   state.ended = true;
+  stream.writable = false;
 }