diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2015-11-03 19:06:50 +0100 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2015-11-06 23:02:11 +0100 |
| commit | 33827e3f6864872f357da6f9566f3c90b138c4ef (patch) | |
| tree | 048e8c57bada24f1258754f90286cc2ba129b147 /node.gyp | |
| parent | df9c4a6a1fe42971e439701a70da61b1155ac57f (diff) | |
| download | node-new-33827e3f6864872f357da6f9566f3c90b138c4ef.tar.gz | |
cluster: remove handles when disconnecting worker
Due to the race window between the master's "disconnect" message and the
worker's "handle received" message, connections sometimes got stuck in
the pending handles queue when calling `worker.disconnect()` in the
master process.
The observable effect from the client's perspective was a TCP or HTTP
connection that simply stalled. This commit fixes that by closing open
handles in the master when the "disconnect" message is sent.
Fixes: https://github.com/nodejs/node/issues/3551
PR-URL: https://github.com/nodejs/node/pull/3677
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -70,6 +70,7 @@ 'lib/vm.js', 'lib/zlib.js', 'lib/internal/child_process.js', + 'lib/internal/cluster.js', 'lib/internal/freelist.js', 'lib/internal/linkedlist.js', 'lib/internal/module.js', |