build: reduce chance of unneeded rebuild

Run `node_js2c` and `mkssldef` as actions and not as targets makes sure
they are run only once, just before processing the rest of `node_lib`.
This helps `make` based dependency change detection be more accurate.

Add comments with tagrget names for readability.

Use `process_outputs_as_sources` for automatic inclution of outputs.

PR-URL: https://github.com/nodejs/node/pull/23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

1 files changed, 10 insertions, 0 deletions

diff --git a/node.gypi b/node.gypi
index db29084335..fe133039d3 100644
--- a/node.gypi
+++ b/node.gypi
@@ -24,6 +24,16 @@
     },
     'force_load%': '<(force_load)',
   },
+  # Putting these explicitly here so not to be dependant on common.gypi.
+  'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
+  'xcode_settings': {
+    'WARNING_CFLAGS': [
+      '-Wall',
+      '-Wendif-labels',
+      '-W',
+      '-Wno-unused-parameter',
+    ],
+  },
   'conditions': [
     [ 'node_shared=="false"', {
       'msvs_settings': {