summaryrefslogtreecommitdiff
path: root/src/env-inl.h
diff options
context:
space:
mode:
authorTrevor Norris <trev.norris@gmail.com>2016-02-11 13:09:52 -0700
committerTrevor Norris <trev.norris@gmail.com>2016-02-12 14:03:17 -0700
commit575b84ec41b94d4a565b981c146d88ce0637fff2 (patch)
treed7d4717aa72c2876bfc28503c170735339bc6625 /src/env-inl.h
parent72c5458aee5c4542163f1f3ad01de837e0a8c0d9 (diff)
downloadnode-new-575b84ec41b94d4a565b981c146d88ce0637fff2.tar.gz
src: fix MakeCallback error handling
Implementations of error handling between node::MakeCallback() and AsyncWrap::MakeCallback() do not return at the same point. Make both executions work the same by moving the early return if there's a caught exception just after the AsyncWrap post callback. Since the domain's call stack is cleared on a caught exception there is no reason to call its exit() callback. Remove the SetVerbose() statement in the AsyncWrap pre/post callback calls since it does not affect the callback call. PR-URL: https://github.com/nodejs/node/pull/4507 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/env-inl.h')
0 files changed, 0 insertions, 0 deletions