diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-12-16 13:21:41 +0100 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2014-12-18 19:39:30 +0100 |
commit | dab6f681cd8c43351aa56f4deb2e327c8e4c5cfe (patch) | |
tree | 797cf30a166d72adc26020ae7d667e0fc7aa435c /src/env-inl.h | |
parent | ebf9f297b30d6cf2e5060da91d63cebbedc448e2 (diff) | |
download | node-new-dab6f681cd8c43351aa56f4deb2e327c8e4c5cfe.tar.gz |
lib,src: remove post-gc event infrastructure
Remove the 'gc' event from the v8 module and remove the supporting
infrastructure from src/. It gets the axe because:
1. There are currently no users. It was originally conceived as
an upstreamed subset of StrongLoop's strong-agent GC metrics,
but the strong-agent code base has evolved considerably since
that time and has no use anymore for what is in core.
2. The implementation is not quite sound. It calls into JS land
from inside the GC epilog and that is unsafe. We could fix
that by delaying the callback until a safe time but because
there are no users anyway, removing it is all around easier.
PR-URL: https://github.com/iojs/io.js/pull/174
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/env-inl.h')
-rw-r--r-- | src/env-inl.h | 39 |
1 files changed, 1 insertions, 38 deletions
diff --git a/src/env-inl.h b/src/env-inl.h index 4ccf899a46..e38f5a8d16 100644 --- a/src/env-inl.h +++ b/src/env-inl.h @@ -34,40 +34,6 @@ namespace node { -inline Environment::GCInfo::GCInfo() - : type_(static_cast<v8::GCType>(0)), - flags_(static_cast<v8::GCCallbackFlags>(0)), - timestamp_(0) { -} - -inline Environment::GCInfo::GCInfo(v8::Isolate* isolate, - v8::GCType type, - v8::GCCallbackFlags flags, - uint64_t timestamp) - : type_(type), - flags_(flags), - timestamp_(timestamp) { - isolate->GetHeapStatistics(&stats_); -} - -inline v8::GCType Environment::GCInfo::type() const { - return type_; -} - -inline v8::GCCallbackFlags Environment::GCInfo::flags() const { - return flags_; -} - -inline v8::HeapStatistics* Environment::GCInfo::stats() const { - // TODO(bnoordhuis) Const-ify once https://codereview.chromium.org/63693005 - // lands and makes it way into a stable release. - return const_cast<v8::HeapStatistics*>(&stats_); -} - -inline uint64_t Environment::GCInfo::timestamp() const { - return timestamp_; -} - inline Environment::IsolateData* Environment::IsolateData::Get( v8::Isolate* isolate) { return static_cast<IsolateData*>(isolate->GetData(kIsolateSlot)); @@ -99,9 +65,7 @@ inline Environment::IsolateData::IsolateData(v8::Isolate* isolate, PropertyName ## _(isolate, FIXED_ONE_BYTE_STRING(isolate, StringValue)), PER_ISOLATE_STRING_PROPERTIES(V) #undef V - ref_count_(0) { - QUEUE_INIT(&gc_tracker_queue_); -} + ref_count_(0) {} inline uv_loop_t* Environment::IsolateData::event_loop() const { return event_loop_; @@ -231,7 +195,6 @@ inline Environment::Environment(v8::Local<v8::Context> context, set_binding_cache_object(v8::Object::New(isolate())); set_module_load_list_array(v8::Array::New(isolate())); RB_INIT(&cares_task_list_); - QUEUE_INIT(&gc_tracker_queue_); QUEUE_INIT(&req_wrap_queue_); QUEUE_INIT(&handle_wrap_queue_); QUEUE_INIT(&handle_cleanup_queue_); |