diff options
| author | cjihrig <cjihrig@gmail.com> | 2020-06-05 14:22:39 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2020-06-08 21:31:56 -0400 |
| commit | 921f75534cdc2ad6fdc61c573d18f61ca14b35da (patch) | |
| tree | 7b34a5b6e34ff2357fa74902cdf8371bd178a735 /src/inspector_socket_server.cc | |
| parent | fd7e40854c447234a05dc3ef0ee717cad138c681 (diff) | |
| download | node-new-921f75534cdc2ad6fdc61c573d18f61ca14b35da.tar.gz | |
inspector: drop 'chrome-' from inspector url
It has been reported that the
https://github.com/cjihrig/node-v8-inspector V8 inspector
extension can no longer connect DevTools (despite no code changes
to the extension since Feb. 2017). Upon investigation, Chrome
dropped support for the chrome-devtools: scheme recently. I've
confirmed that dropping 'chrome-' from the URL here allows the
debugger to function properly with modern Chrome.
Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779
PR-URL: https://github.com/nodejs/node/pull/33758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/inspector_socket_server.cc')
| -rw-r--r-- | src/inspector_socket_server.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inspector_socket_server.cc b/src/inspector_socket_server.cc index 9e27bd30f7..29e0c12802 100644 --- a/src/inspector_socket_server.cc +++ b/src/inspector_socket_server.cc @@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket, std::string InspectorSocketServer::GetFrontendURL(bool is_compat, const std::string &formatted_address) { std::ostringstream frontend_url; - frontend_url << "chrome-devtools://devtools/bundled/"; + frontend_url << "devtools://devtools/bundled/"; frontend_url << (is_compat ? "inspector" : "js_app"); frontend_url << ".html?experiments=true&v8only=true&ws="; frontend_url << formatted_address; |