summaryrefslogtreecommitdiff
path: root/src/node.cc
diff options
context:
space:
mode:
authorDaniel Bevenius <daniel.bevenius@gmail.com>2017-05-03 19:17:22 +0200
committerMyles Borins <mylesborins@google.com>2017-08-15 20:57:22 -0700
commit403c45fcc9a70acfd8d2429fa96ddcef0c0b0ad4 (patch)
tree436bec5b83b01b19f16003d9d74103a718cfca59 /src/node.cc
parent7fed989deb18c9caaae1f950790c232a3f2e0a25 (diff)
downloadnode-new-403c45fcc9a70acfd8d2429fa96ddcef0c0b0ad4.tar.gz
src: only call FatalException if not verbose
This commit attempts to address the TODO regarding not calling FatalException if the try_catch is verbose. PR-URL: https://github.com/nodejs/node/pull/12826 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/node.cc')
-rw-r--r--src/node.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/node.cc b/src/node.cc
index dfe84c67c1..62648dbb3f 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -2602,9 +2602,9 @@ void FatalException(Isolate* isolate,
void FatalException(Isolate* isolate, const TryCatch& try_catch) {
HandleScope scope(isolate);
- // TODO(bajtos) do not call FatalException if try_catch is verbose
- // (requires V8 API to expose getter for try_catch.is_verbose_)
- FatalException(isolate, try_catch.Exception(), try_catch.Message());
+ if (!try_catch.IsVerbose()) {
+ FatalException(isolate, try_catch.Exception(), try_catch.Message());
+ }
}