diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-01-16 11:12:30 -0800 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-01-29 00:27:42 +0100 |
commit | 46c5c3388d24615d8bcd887bb366d4171e99fdee (patch) | |
tree | 12ca4fef0e7df35ba0e2028cc7fd6cd3e08a81c3 /src/node_crypto_clienthello.h | |
parent | dd317fc1c866297f5c91a14a8b26525b8120288f (diff) | |
download | node-new-46c5c3388d24615d8bcd887bb366d4171e99fdee.tar.gz |
src: in-source comments and minor TLS cleanups
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
PR-URL: https://github.com/nodejs/node/pull/25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/node_crypto_clienthello.h')
-rw-r--r-- | src/node_crypto_clienthello.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/node_crypto_clienthello.h b/src/node_crypto_clienthello.h index 2ced72c4e8..48f49771fd 100644 --- a/src/node_crypto_clienthello.h +++ b/src/node_crypto_clienthello.h @@ -30,6 +30,9 @@ namespace node { namespace crypto { +// Parse the client hello so we can do async session resumption. OpenSSL's +// session resumption uses synchronous callbacks, see SSL_CTX_sess_set_get_cb +// and get_session_cb. class ClientHelloParser { public: inline ClientHelloParser(); |