summaryrefslogtreecommitdiff
path: root/src/node_provider.d
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2014-03-15 02:04:02 +0100
committerFedor Indutny <fedor.indutny@gmail.com>2014-03-16 16:15:34 +0400
commitc30cc4e3a5ead3ca5b48e8eec445740775888ed8 (patch)
treeaf71c08d61697753c053098f0bd5c8727c0f419e /src/node_provider.d
parente87ceb2b427a9b51a55af5898c2ef24b4cc08af2 (diff)
downloadnode-new-c30cc4e3a5ead3ca5b48e8eec445740775888ed8.tar.gz
src: don't call DecodeWrite() on Buffers
Don't call DecodeWrite() with a Buffer as its argument because it in turn calls StringBytes::Write() and that method expects a Local<String>. "Why then does that function take a Local<Value>?" I hear you ask. Good question but I don't have the answer. I added a CHECK for good measure and what do you know, all of a sudden a large number of crypto tests started failing. Calling DecodeWrite(BINARY) on a buffer is nonsensical anyway: if you want the contents of the buffer, just copy out the data, there is no need to decode it - and that's exactly what this commit does. Fixes a great many instances of the following run-time error in debug builds: FATAL ERROR: v8::String::Cast() Could not convert to string
Diffstat (limited to 'src/node_provider.d')
0 files changed, 0 insertions, 0 deletions