diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-02-23 15:21:48 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-03-02 12:58:20 +0000 |
| commit | 7cadb57e0c0459d3c60712744d1519eafc49b556 (patch) | |
| tree | 783e1b712d77ac16f9be171e254698783d3ca27b /src/stream_base-inl.h | |
| parent | 16facd7ef48b9d43af02009524983b05901dc26b (diff) | |
| download | node-new-7cadb57e0c0459d3c60712744d1519eafc49b556.tar.gz | |
src: refactor setting JS properties on WriteWrap
`async` and `bytes` are only interesting when the write
is coming from JS, and unnecessary otherwise.
Also, make all of the stream `Write*()` bindings use the same
code for setting these, and upgrade to the non-deprecated versions.
PR-URL: https://github.com/nodejs/node/pull/18963
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/stream_base-inl.h')
| -rw-r--r-- | src/stream_base-inl.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/stream_base-inl.h b/src/stream_base-inl.h index c864feb927..81adf7a866 100644 --- a/src/stream_base-inl.h +++ b/src/stream_base-inl.h @@ -220,8 +220,6 @@ inline StreamWriteResult StreamBase::Write( ClearError(); } - req_wrap_obj->Set(env->async(), v8::Boolean::New(env->isolate(), async)); - return StreamWriteResult { async, err, req_wrap }; } |