diff options
| author | Anna Henningsen <anna@addaleax.net> | 2017-12-30 12:40:54 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-01-14 14:41:14 +0100 |
| commit | 20f6aaee7308d5f426de11def6ad9de8848222f5 (patch) | |
| tree | 72a250807ae1be3fdcd47747f0ac2d21cc1f6dae /src/stream_base.h | |
| parent | 8b751f7eb7b05a0b27f52e2288a636fdd78e9ecb (diff) | |
| download | node-new-20f6aaee7308d5f426de11def6ad9de8848222f5.tar.gz | |
src: remove `HasWriteQueue()`
Tests are passing without it, and this otherwise makes the
code harder to reason about because the `async` flag on the
write request object would not be set even though the callback
would still be pending.
PR-URL: https://github.com/nodejs/node/pull/18019
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/stream_base.h')
| -rw-r--r-- | src/stream_base.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/stream_base.h b/src/stream_base.h index 071627f3bf..d063176b04 100644 --- a/src/stream_base.h +++ b/src/stream_base.h @@ -162,7 +162,6 @@ class StreamResource { uv_buf_t* bufs, size_t count, uv_stream_t* send_handle) = 0; - virtual bool HasWriteQueue(); virtual const char* Error() const; virtual void ClearError(); |