diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 16:52:07 +0200 |
---|---|---|
committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:46 +0400 |
commit | 5fdff3854a4253681fb10aa626c8971e50834c10 (patch) | |
tree | baa8b219fff28467b641d4f4f36a5b090f6cc6b2 /src/string_bytes.cc | |
parent | 75a461d0997e0a040c2194c5309c148f179563e9 (diff) | |
download | node-new-5fdff3854a4253681fb10aa626c8971e50834c10.tar.gz |
src: replace assert() with CHECK()
Mechanically replace assert() statements with UNREACHABLE(), CHECK(),
or CHECK_{EQ,NE,LT,GT,LE,GE}() statements.
The exceptions are src/node.h and src/node_object_wrap.h because they
are public headers.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/string_bytes.cc')
-rw-r--r-- | src/string_bytes.cc | 23 |
1 files changed, 11 insertions, 12 deletions
diff --git a/src/string_bytes.cc b/src/string_bytes.cc index 38a082fa2b..399854acb7 100644 --- a/src/string_bytes.cc +++ b/src/string_bytes.cc @@ -25,7 +25,6 @@ #include "node_buffer.h" #include "v8.h" -#include <assert.h> #include <limits.h> #include <string.h> // memcpy @@ -378,7 +377,7 @@ size_t StringBytes::Write(Isolate* isolate, break; default: - assert(0 && "unknown encoding"); + CHECK(0 && "unknown encoding"); break; } @@ -435,12 +434,12 @@ size_t StringBytes::StorageSize(Isolate* isolate, break; case HEX: - assert(str->Length() % 2 == 0 && "invalid hex string length"); + CHECK(str->Length() % 2 == 0 && "invalid hex string length"); data_size = str->Length() / 2; break; default: - assert(0 && "unknown encoding"); + CHECK(0 && "unknown encoding"); break; } @@ -490,7 +489,7 @@ size_t StringBytes::Size(Isolate* isolate, break; default: - assert(0 && "unknown encoding"); + CHECK(0 && "unknown encoding"); break; } @@ -610,8 +609,8 @@ static size_t base64_encode(const char* src, char* dst, size_t dlen) { // We know how much we'll write, just make sure that there's space. - assert(dlen >= base64_encoded_size(slen) && - "not enough space provided for base64 encode"); + CHECK(dlen >= base64_encoded_size(slen) && + "not enough space provided for base64 encode"); dlen = base64_encoded_size(slen); @@ -671,7 +670,7 @@ static size_t base64_encode(const char* src, static size_t hex_encode(const char* src, size_t slen, char* dst, size_t dlen) { // We know how much we'll write, just make sure that there's space. - assert(dlen >= slen * 2 && + CHECK(dlen >= slen * 2 && "not enough space provided for hex encode"); dlen = slen * 2; @@ -693,7 +692,7 @@ Local<Value> StringBytes::Encode(Isolate* isolate, enum encoding encoding) { EscapableHandleScope scope(isolate); - assert(buflen <= Buffer::kMaxLength); + CHECK_LE(buflen, Buffer::kMaxLength); if (!buflen && encoding != BUFFER) return scope.Escape(String::Empty(isolate)); @@ -739,7 +738,7 @@ Local<Value> StringBytes::Encode(Isolate* isolate, char* dst = new char[dlen]; size_t written = base64_encode(buf, buflen, dst, dlen); - assert(written == dlen); + CHECK_EQ(written, dlen); if (dlen < EXTERN_APEX) { val = OneByteString(isolate, dst, dlen); @@ -780,7 +779,7 @@ Local<Value> StringBytes::Encode(Isolate* isolate, size_t dlen = buflen * 2; char* dst = new char[dlen]; size_t written = hex_encode(buf, buflen, dst, dlen); - assert(written == dlen); + CHECK_EQ(written, dlen); if (dlen < EXTERN_APEX) { val = OneByteString(isolate, dst, dlen); @@ -792,7 +791,7 @@ Local<Value> StringBytes::Encode(Isolate* isolate, } default: - assert(0 && "unknown encoding"); + CHECK(0 && "unknown encoding"); break; } |