diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2016-10-10 07:52:00 +0200 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2016-10-10 08:45:52 -0700 |
| commit | 1bfa02639c857fb26042c20c8749884f4551a0d1 (patch) | |
| tree | b14cf1cda4da1643976fbca8f2df2b1266700c5c /src/udp_wrap.cc | |
| parent | 2aa2f85e467120959778e8fab9b69b72959f1856 (diff) | |
| download | node-new-1bfa02639c857fb26042c20c8749884f4551a0d1.tar.gz | |
src: remove out-of-date TODO comment
This commit attempts to fix one of the items in
https://github.com/nodejs/node/issues/4641, which was to remove a
TODO the UDPWrap::OnSend function and share the code in that method with
StreamWrap::AfterWrite.
While looking into this addaleax pointed out that the implementations
for these two functions have diverged since the original comment
was added:
$ git log --pretty=short -u -L 357,357:src/udp_wrap.cc
$ git show cbd4033619cc45abdf878285c412bac9c3f36e4e:src/udp_wrap.cc |
grep -1 -A26 'UDPWrap::OnSend'
git show cbd4033619cc45abdf878285c412bac9c3f36e4e:src/stream_wrap.cc |
grep -A27 'void StreamWrap::AfterWrite'
Removing the TODO comment seems appropriate in this case.
PR-URL: https://github.com/nodejs/node/pull/9000
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/udp_wrap.cc')
| -rw-r--r-- | src/udp_wrap.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/udp_wrap.cc b/src/udp_wrap.cc index 4d6b2377ec..d14eefd64d 100644 --- a/src/udp_wrap.cc +++ b/src/udp_wrap.cc @@ -354,7 +354,6 @@ void UDPWrap::RecvStop(const FunctionCallbackInfo<Value>& args) { } -// TODO(bnoordhuis) share with StreamWrap::AfterWrite() in stream_wrap.cc void UDPWrap::OnSend(uv_udp_send_t* req, int status) { SendWrap* req_wrap = static_cast<SendWrap*>(req->data); if (req_wrap->have_callback()) { |