diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-09-27 08:20:53 +0200 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-10-01 08:26:30 +0200 |
| commit | 5c855a7334e27fdff2fde9eae084adf588e1a135 (patch) | |
| tree | efa6ecd254fa70bb0a79d0d224e3e7bc34803baf /src | |
| parent | 7ac109df10eb8d31bb7503b031ff85a14bb5ec84 (diff) | |
| download | node-new-5c855a7334e27fdff2fde9eae084adf588e1a135.tar.gz | |
src: make req_wrap a unique_ptr in AfterConnect
PR-URL: https://github.com/nodejs/node/pull/23115
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/connection_wrap.cc | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/connection_wrap.cc b/src/connection_wrap.cc index 3021307c06..db239f9bec 100644 --- a/src/connection_wrap.cc +++ b/src/connection_wrap.cc @@ -77,7 +77,8 @@ void ConnectionWrap<WrapType, UVType>::OnConnection(uv_stream_t* handle, template <typename WrapType, typename UVType> void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req, int status) { - ConnectWrap* req_wrap = static_cast<ConnectWrap*>(req->data); + std::unique_ptr<ConnectWrap> req_wrap + (static_cast<ConnectWrap*>(req->data)); CHECK_NOT_NULL(req_wrap); WrapType* wrap = static_cast<WrapType*>(req->handle->data); CHECK_EQ(req_wrap->env(), wrap->env()); @@ -108,8 +109,6 @@ void ConnectionWrap<WrapType, UVType>::AfterConnect(uv_connect_t* req, }; req_wrap->MakeCallback(env->oncomplete_string(), arraysize(argv), argv); - - delete req_wrap; } template ConnectionWrap<PipeWrap, uv_pipe_t>::ConnectionWrap( |