diff options
author | Anna Henningsen <anna@addaleax.net> | 2020-07-14 17:45:39 +0200 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2020-07-20 18:13:28 +0200 |
commit | 2c4ebe0426616e6a5016b6d77f6ca72a9548be93 (patch) | |
tree | d3d706eeea70a372b12c9d8628e436ada7f35958 /test/internet | |
parent | da95dd773216a7fe7bf985014f3920893cbdf23d (diff) | |
download | node-new-2c4ebe0426616e6a5016b6d77f6ca72a9548be93.tar.gz |
test: use `.then(common.mustCall())` for all async IIFEs
This makes sure that all async functions finish as expected.
PR-URL: https://github.com/nodejs/node/pull/34363
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'test/internet')
-rw-r--r-- | test/internet/test-dns-promises-resolve.js | 4 | ||||
-rw-r--r-- | test/internet/test-dns-txt-sigsegv.js | 4 | ||||
-rw-r--r-- | test/internet/test-dns.js | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/test/internet/test-dns-promises-resolve.js b/test/internet/test-dns-promises-resolve.js index a482cba60a..ed9c95a010 100644 --- a/test/internet/test-dns-promises-resolve.js +++ b/test/internet/test-dns-promises-resolve.js @@ -1,5 +1,5 @@ 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const dnsPromises = require('dns').promises; @@ -38,5 +38,5 @@ const dnsPromises = require('dns').promises; const result = await dnsPromises.resolve('example.org', rrtype); assert.ok(result !== undefined); assert.ok(result.length > 0); - })(); + })().then(common.mustCall()); } diff --git a/test/internet/test-dns-txt-sigsegv.js b/test/internet/test-dns-txt-sigsegv.js index 9f65b6ec24..eeebf28fc7 100644 --- a/test/internet/test-dns-txt-sigsegv.js +++ b/test/internet/test-dns-txt-sigsegv.js @@ -1,5 +1,5 @@ 'use strict'; -require('../common'); +const common = require('../common'); const assert = require('assert'); const dns = require('dns'); const dnsPromises = dns.promises; @@ -7,7 +7,7 @@ const dnsPromises = dns.promises; (async function() { const result = await dnsPromises.resolveTxt('www.microsoft.com'); assert.strictEqual(result.length, 0); -})(); +})().then(common.mustCall()); dns.resolveTxt('www.microsoft.com', function(err, records) { assert.strictEqual(err, null); diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js index c74acc50dd..e5092b6ea2 100644 --- a/test/internet/test-dns.js +++ b/test/internet/test-dns.js @@ -708,4 +708,4 @@ dns.lookupService('0.0.0.0', 0, common.mustCall()); (async function() { await dnsPromises.lookup(addresses.INET6_HOST, 6); await dnsPromises.lookup(addresses.INET_HOST, {}); -})(); +})().then(common.mustCall()); |