diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-12-25 18:02:16 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-12-31 15:54:20 +0100 |
commit | e038d6a1cdb2ffbf666d360553c31786acaf70b2 (patch) | |
tree | 214bcc4550360f2497fe82e85154df0859ff35b4 /test/internet | |
parent | e66c4deda8c63ca6c1557eed7c09ba01c6284e57 (diff) | |
download | node-new-e038d6a1cdb2ffbf666d360553c31786acaf70b2.tar.gz |
test: refactor common.expectsError
This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.
The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.
This has the side effect that `common` is used significantly less
frequent.
PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'test/internet')
-rw-r--r-- | test/internet/test-dns-promises-resolve.js | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/test/internet/test-dns-promises-resolve.js b/test/internet/test-dns-promises-resolve.js index b9e7fa4230..a482cba60a 100644 --- a/test/internet/test-dns-promises-resolve.js +++ b/test/internet/test-dns-promises-resolve.js @@ -1,5 +1,5 @@ 'use strict'; -const common = require('../common'); +require('../common'); const assert = require('assert'); const dnsPromises = require('dns').promises; @@ -7,11 +7,11 @@ const dnsPromises = require('dns').promises; // Error when rrtype is invalid. { const rrtype = 'DUMMY'; - common.expectsError( + assert.throws( () => dnsPromises.resolve('example.org', rrtype), { code: 'ERR_INVALID_OPT_VALUE', - type: TypeError, + name: 'TypeError', message: `The value "${rrtype}" is invalid for option "rrtype"` } ); @@ -20,11 +20,11 @@ const dnsPromises = require('dns').promises; // Error when rrtype is a number. { const rrtype = 0; - common.expectsError( + assert.throws( () => dnsPromises.resolve('example.org', rrtype), { code: 'ERR_INVALID_ARG_TYPE', - type: TypeError, + name: 'TypeError', message: 'The "rrtype" argument must be of type string. ' + `Received type ${typeof rrtype} (${rrtype})` } |