summaryrefslogtreecommitdiff
path: root/test/parallel/test-dgram-error-message-address.js
diff options
context:
space:
mode:
authorBrian White <mscdex@mscdex.net>2016-05-29 03:06:56 -0400
committerBrian White <mscdex@mscdex.net>2016-06-10 22:30:55 -0400
commit2bc7841d0fcdd066fe477873229125b6f003b693 (patch)
tree2816555ef6ad2fc828a75dc3c564f8faa2dee6c7 /test/parallel/test-dgram-error-message-address.js
parent624734e640717a826ab1a18845c083a638dc5ce6 (diff)
downloadnode-new-2bc7841d0fcdd066fe477873229125b6f003b693.tar.gz
test: use random ports where possible
This helps to prevent issues where a failed test can keep a bound socket open long enough to cause other tests to fail with EADDRINUSE because the same port number is used. PR-URL: https://github.com/nodejs/node/pull/7045 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Diffstat (limited to 'test/parallel/test-dgram-error-message-address.js')
-rw-r--r--test/parallel/test-dgram-error-message-address.js12
1 files changed, 6 insertions, 6 deletions
diff --git a/test/parallel/test-dgram-error-message-address.js b/test/parallel/test-dgram-error-message-address.js
index 005695654f..d27b004332 100644
--- a/test/parallel/test-dgram-error-message-address.js
+++ b/test/parallel/test-dgram-error-message-address.js
@@ -9,14 +9,14 @@ var socket_ipv4 = dgram.createSocket('udp4');
socket_ipv4.on('listening', common.fail);
socket_ipv4.on('error', common.mustCall(function(e) {
- assert.equal(e.message, 'bind EADDRNOTAVAIL 1.1.1.1:' + common.PORT);
+ assert.strictEqual(e.port, undefined);
+ assert.equal(e.message, 'bind EADDRNOTAVAIL 1.1.1.1');
assert.equal(e.address, '1.1.1.1');
- assert.equal(e.port, common.PORT);
assert.equal(e.code, 'EADDRNOTAVAIL');
socket_ipv4.close();
}));
-socket_ipv4.bind(common.PORT, '1.1.1.1');
+socket_ipv4.bind(0, '1.1.1.1');
// IPv6 Test
var socket_ipv6 = dgram.createSocket('udp6');
@@ -27,10 +27,10 @@ socket_ipv6.on('error', common.mustCall(function(e) {
// EAFNOSUPPORT or EPROTONOSUPPORT means IPv6 is disabled on this system.
var allowed = ['EADDRNOTAVAIL', 'EAFNOSUPPORT', 'EPROTONOSUPPORT'];
assert.notEqual(allowed.indexOf(e.code), -1);
- assert.equal(e.message, 'bind ' + e.code + ' 111::1:' + common.PORT);
+ assert.strictEqual(e.port, undefined);
+ assert.equal(e.message, 'bind ' + e.code + ' 111::1');
assert.equal(e.address, '111::1');
- assert.equal(e.port, common.PORT);
socket_ipv6.close();
}));
-socket_ipv6.bind(common.PORT, '111::1');
+socket_ipv6.bind(0, '111::1');