summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-empty-readStream.js
diff options
context:
space:
mode:
authorAdrian Estrada <edsadr@gmail.com>2016-12-27 21:43:44 -0500
committerJames M Snell <jasnell@gmail.com>2016-12-30 09:14:53 -0800
commit6463ef6affa73794a5ad33108997c430d02acf2c (patch)
tree189def1babe122a93545933ef5e1078438a5471a /test/parallel/test-fs-empty-readStream.js
parent1bee74de84ae7bb602fcf195b8cf72c5cf09b2e3 (diff)
downloadnode-new-6463ef6affa73794a5ad33108997c430d02acf2c.tar.gz
test: improve test-fs-empty-readStream.js
* use const instead of var * use common.mustCall to control functions execution * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10479 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Diffstat (limited to 'test/parallel/test-fs-empty-readStream.js')
-rw-r--r--test/parallel/test-fs-empty-readStream.js32
1 files changed, 16 insertions, 16 deletions
diff --git a/test/parallel/test-fs-empty-readStream.js b/test/parallel/test-fs-empty-readStream.js
index c5a016f9ea..858d07e4f0 100644
--- a/test/parallel/test-fs-empty-readStream.js
+++ b/test/parallel/test-fs-empty-readStream.js
@@ -1,30 +1,30 @@
'use strict';
-var common = require('../common');
-var assert = require('assert');
-var path = require('path');
-var fs = require('fs');
+const common = require('../common');
+const assert = require('assert');
+const path = require('path');
+const fs = require('fs');
-var emptyFile = path.join(common.fixturesDir, 'empty.txt');
+const emptyFile = path.join(common.fixturesDir, 'empty.txt');
-fs.open(emptyFile, 'r', function(error, fd) {
+fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);
- var read = fs.createReadStream(emptyFile, { 'fd': fd });
+ const read = fs.createReadStream(emptyFile, { 'fd': fd });
- read.once('data', function() {
+ read.once('data', () => {
throw new Error('data event should not emit');
});
read.once('end', common.mustCall(function endEvent1() {}));
-});
+}));
-fs.open(emptyFile, 'r', function(error, fd) {
+fs.open(emptyFile, 'r', common.mustCall((error, fd) => {
assert.ifError(error);
- var read = fs.createReadStream(emptyFile, { 'fd': fd });
+ const read = fs.createReadStream(emptyFile, { 'fd': fd });
read.pause();
- read.once('data', function() {
+ read.once('data', () => {
throw new Error('data event should not emit');
});
@@ -32,7 +32,7 @@ fs.open(emptyFile, 'r', function(error, fd) {
throw new Error('end event should not emit');
});
- setTimeout(function() {
- assert.equal(read.isPaused(), true);
- }, common.platformTimeout(50));
-});
+ setTimeout(common.mustCall(() => {
+ assert.strictEqual(read.isPaused(), true);
+ }), common.platformTimeout(50));
+}));