diff options
| author | ZYSzys <zyszys98@gmail.com> | 2019-10-03 23:07:42 +0800 |
|---|---|---|
| committer | ZYSzys <zyszys98@gmail.com> | 2019-10-05 23:51:03 +0800 |
| commit | f0bee9b490e55ae93da1d1f8a485a4a432e61575 (patch) | |
| tree | b96d6599cbe718f73538d729ed0a85b36c08f24d /test/parallel/test-http2-getpackedsettings.js | |
| parent | 24011de9071fcd092fab29719d3fa8269a95288a (diff) | |
| download | node-new-f0bee9b490e55ae93da1d1f8a485a4a432e61575.tar.gz | |
http2: set default maxConcurrentStreams
Set the default maxConcurrentStreams to
NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS.
PR-URL: https://github.com/nodejs/node/pull/29833
Fixes: https://github.com/nodejs/node/issues/29763
Refs: https://github.com/nghttp2/nghttp2/commit/16c46114dc724278beaa6d59462f8396f35fa4a9
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Diffstat (limited to 'test/parallel/test-http2-getpackedsettings.js')
| -rw-r--r-- | test/parallel/test-http2-getpackedsettings.js | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/test/parallel/test-http2-getpackedsettings.js b/test/parallel/test-http2-getpackedsettings.js index 77c8cf442f..341cfb4fc7 100644 --- a/test/parallel/test-http2-getpackedsettings.js +++ b/test/parallel/test-http2-getpackedsettings.js @@ -7,6 +7,7 @@ const assert = require('assert'); const http2 = require('http2'); const check = Buffer.from([0x00, 0x01, 0x00, 0x00, 0x10, 0x00, + 0x00, 0x03, 0xff, 0xff, 0xff, 0xff, 0x00, 0x05, 0x00, 0x00, 0x40, 0x00, 0x00, 0x04, 0x00, 0x00, 0xff, 0xff, 0x00, 0x06, 0x00, 0x00, 0xff, 0xff, @@ -41,7 +42,7 @@ http2.getPackedSettings({ enablePush: false }); ['maxFrameSize', 16383], ['maxFrameSize', 2 ** 24], ['maxConcurrentStreams', -1], - ['maxConcurrentStreams', 2 ** 31], + ['maxConcurrentStreams', 2 ** 32], ['maxHeaderListSize', -1], ['maxHeaderListSize', 2 ** 32] ].forEach((i) => { @@ -168,16 +169,3 @@ http2.getPackedSettings({ enablePush: false }); message: 'Invalid value for setting "maxFrameSize": 16777216' }); } - -// Check for maxConcurrentStreams failing the max number. -{ - const packed = Buffer.from([0x00, 0x03, 0xFF, 0xFF, 0xFF, 0xFF]); - - common.expectsError(() => { - http2.getUnpackedSettings(packed, { validate: true }); - }, { - code: 'ERR_HTTP2_INVALID_SETTING_VALUE', - type: RangeError, - message: 'Invalid value for setting "maxConcurrentStreams": 4294967295' - }); -} |