test: refactor common.expectsError

This completely refactors the `expectsError` behavior: so far it's
almost identical to `assert.throws(fn, object)` in case it was used
with a function as first argument. It had a magical property check
that allowed to verify a functions `type` in case `type` was passed
used in the validation object. This pattern is now completely removed
and `assert.throws()` should be used instead.

The main intent for `common.expectsError()` is to verify error cases
for callback based APIs. This is now more flexible by accepting all
validation possibilites that `assert.throws()` accepts as well. No
magical properties exist anymore. This reduces surprising behavior
for developers who are not used to the Node.js core code base.

This has the side effect that `common` is used significantly less
frequent.

PR-URL: https://github.com/nodejs/node/pull/31092
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/test/parallel/test-net-connect-options-port.js b/test/parallel/test-net-connect-options-port.js
index c22630d433..88e626354e 100644
--- a/test/parallel/test-net-connect-options-port.js
+++ b/test/parallel/test-net-connect-options-port.js
@@ -27,10 +27,10 @@ const net = require('net');
 
 // Test wrong type of ports
 {
-  const portTypeError = common.expectsError({
+  const portTypeError = {
     code: 'ERR_INVALID_ARG_TYPE',
-    type: TypeError
-  }, 96);
+    name: 'TypeError'
+  };
 
   syncFailToConnect(true, portTypeError);
   syncFailToConnect(false, portTypeError);
@@ -41,10 +41,10 @@ const net = require('net');
 
 // Test out of range ports
 {
-  const portRangeError = common.expectsError({
+  const portRangeError = {
     code: 'ERR_SOCKET_BAD_PORT',
-    type: RangeError
-  }, 168);
+    name: 'RangeError'
+  };
 
   syncFailToConnect('', portRangeError);
   syncFailToConnect(' ', portRangeError);
@@ -63,9 +63,9 @@ const net = require('net');
   const hintOptBlocks = doConnect([{ hints }],
                                   () => common.mustNotCall());
   for (const fn of hintOptBlocks) {
-    common.expectsError(fn, {
+    assert.throws(fn, {
       code: 'ERR_INVALID_OPT_VALUE',
-      type: TypeError,
+      name: 'TypeError',
       message: /The value "\d+" is invalid for option "hints"/
     });
   }