diff options
| author | Gibson Fahnestock <gibfahn@gmail.com> | 2017-05-28 13:35:33 +0100 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-06-05 12:23:01 -0700 |
| commit | 81ddeb98f6a0f7a5165cd6e3b87cdaa550fdf3ec (patch) | |
| tree | ca527281a3d5cbb711bbdc373e3c627f9313df77 /test/parallel/test-readline-set-raw-mode.js | |
| parent | bccda4f2b8b37bf8cce771e56780caafea5078a2 (diff) | |
| download | node-new-81ddeb98f6a0f7a5165cd6e3b87cdaa550fdf3ec.tar.gz | |
readline: clean up event listener in onNewListener
Once the Readline interface is closed, the 'data' event listener should
be removed.
PR-URL: https://github.com/nodejs/node/pull/13266
Ref: https://github.com/nodejs/node/pull/9447#discussion_r86599214
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/parallel/test-readline-set-raw-mode.js')
| -rw-r--r-- | test/parallel/test-readline-set-raw-mode.js | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/test/parallel/test-readline-set-raw-mode.js b/test/parallel/test-readline-set-raw-mode.js index db42a5a949..ddffd131d0 100644 --- a/test/parallel/test-readline-set-raw-mode.js +++ b/test/parallel/test-readline-set-raw-mode.js @@ -74,6 +74,8 @@ assert(!rawModeCalled); assert(resumeCalled); assert(!pauseCalled); +// One data listener for the keypress events. +assert.strictEqual(stream.listeners('data').length, 1); // close() should call setRawMode(false) expectedRawMode = false; @@ -86,5 +88,5 @@ assert(!resumeCalled); assert(pauseCalled); assert.deepStrictEqual(stream.listeners('keypress'), []); -// one data listener for the keypress events. -assert.strictEqual(stream.listeners('data').length, 1); +// Data listener is removed once interface is closed. +assert.strictEqual(stream.listeners('data').length, 0); |